Synthesis: AssetPackager released!

AssetPackager released!

sbecker — Mon, 19 Jun 2006 09:33:00 -0700

Asset Packager has been released! (Formerly known as MergeJS) New features include:

support for css files
versioning of individual packages
use of more meaningful subversion revision numbers (if available) (thanks Chris Van Pelt!)
namespaced rake tasks
no more revision numbers in the yaml file
lotsa refactoring
unit tests
more intuitive names for everything!

Go here to check it out: AssetPackager

"AssetPackager released!" by Klaus Hartl

Wed, 14 May 2008 06:56:11 -0700

@Joel that worked better for me (based on r57):


source << ".#{ext}" if File.extname(source).blank? && ext || ext =~ /css|js/ && File.extname(source).delete('.') != ext

"AssetPackager released!" by Klaus Hartl

Wed, 14 May 2008 06:55:07 -0700

@Joel that worked better for me (based on r57):


source << ".#{ext}" if File.extname(source).blank? && ext || ext =~ /css|js/ && File.extname(source).delete('.') != ext

"AssetPackager released!" by Klaus Hartl

Wed, 14 May 2008 06:53:36 -0700

@Joel that worked better for me (based on r57):


source << ".#{ext}" if File.extname(source).blank? && ext || ext =~ /css|js/ && File.extname(source).delete('.') != ext

"AssetPackager released!" by Klaus Hartl

Wed, 14 May 2008 02:58:25 -0700

I am getting a “Service Temporarily Unavailable” error for the tracker, thus I’m posting it here:

I recently ran into a subtle bug with compressed style sheets. If you have a comment in a property or value without a following white space like this:

property: /**/value;

the parser will not see the end of this comment and instead strip away everything up until it encounters the next closing comment.

"AssetPackager released!" by Joel

Sat, 29 Mar 2008 06:21:58 -0700

Sorry about the triple(?!) posts.. Didnt see the update =)

"AssetPackager released!" by Joel

Sat, 29 Mar 2008 06:21:11 -0700

Seems like the compute_public_path has some trouble with file names containing periods (common in jquery libs among others).

The .js either does not get appended (in development) or if u explicit set it in the asset_packages.yml it gets appended even if it should not.

Hackfix:


  line 41: source << ".#{ext}" if File.extname(source).blank?
  === changed to:
  source << ".#{ext}" if File.extname(source).blank? || (!ext.nil? && File.extname(source) != ext)

Seems to fix it.

"AssetPackager released!" by Joel

Sat, 29 Mar 2008 06:21:05 -0700

Seems like the compute_public_path has some trouble with file names containing periods (common in jquery libs among others).

The .js either does not get appended (in development) or if u explicit set it in the asset_packages.yml it gets appended even if it should not.

Hackfix:


  line 41: source << ".#{ext}" if File.extname(source).blank?
  === changed to:
  source << ".#{ext}" if File.extname(source).blank? || (!ext.nil? && File.extname(source) != ext)

Seems to fix it.

"AssetPackager released!" by Joel

Sat, 29 Mar 2008 06:20:51 -0700

Seems like the compute_public_path has some trouble with file names containing periods (common in jquery libs among others).

The .js either does not get appended (in development) or if u explicit set it in the asset_packages.yml it gets appended even if it should not.

Hackfix:


  line 41: source << ".#{ext}" if File.extname(source).blank?
  === changed to:
  source << ".#{ext}" if File.extname(source).blank? || (!ext.nil? && File.extname(source) != ext)

Seems to fix it.

"AssetPackager released!" by Jim

Tue, 18 Mar 2008 18:44:33 -0700

I see that Synthesis::AssetPackage.build_all has a dependency on the “get_file_revision” method which depends on SVN.

Has an update been released to make this Git compatible?

"AssetPackager released!" by Jim

Tue, 18 Mar 2008 18:44:22 -0700

I see that Synthesis::AssetPackage.build_all has a dependency on the “get_file_revision” method which depends on SVN.

Has an update been released to make this Git compatible?

"AssetPackager released!" by David Vanderson

Fri, 14 Mar 2008 15:11:04 -0700

Thanks for the great plugin!

One issue that I ran into was the svn command dying when running under mongrel versions > 1.0.2 that are launched as root but drop their privileges. You get this error message in the mongrel log:

svn: Can't check path '/root/.subversion': Permission denied

$HOME is still /root, so svn tries to look for /root/.subversion, which throws an exception (due to permissions), which eventually returns a default revision of 1. In my case I worked around it by adding “—config-dir /does-not-exist” to the svn command.

Thanks again,
Dave

"AssetPackager released!" by David Vanderson

Fri, 14 Mar 2008 15:10:29 -0700

Thanks for the great plugin!

One issue that I ran into was the svn command dying when running under mongrel versions > 1.0.2 that are launched as root but drop their privileges. You get this error message in the mongrel log:

svn: Can't check path '/root/.subversion': Permission denied

Thanks again,
Dave

"AssetPackager released!" by David Vanderson

Fri, 14 Mar 2008 15:10:19 -0700

Thanks for the great plugin!

One issue that I ran into was the svn command dying when running under mongrel versions > 1.0.2 that are launched as root but drop their privileges. You get this error message in the mongrel log:

svn: Can't check path '/root/.subversion': Permission denied

Thanks again,
Dave

"AssetPackager released!" by Farsça tercüme

Thu, 28 Feb 2008 13:36:01 -0800

Your comment contains very useful information about all thank you farsça tercüman

"AssetPackager released!" by Jyrki J. Lilja

Wed, 27 Feb 2008 12:51:00 -0800

This seems to fix the problem:


--- a/vendor/plugins/asset_packager/lib/synthesis/asset_package_helper.rb
+++ b/vendor/plugins/asset_packager/lib/synthesis/asset_package_helper.rb
@@ -21,7 +21,10 @@ module Synthesis
         AssetPackage.targets_from_sources("javascripts", sources) : 
         AssetPackage.sources_from_targets("javascripts", sources))

-      sources.collect {|source| javascript_include_tag(source, options) }.join("\n")
+      sources.collect { |source|
+        source = javascript_path(source)
+        content_tag("script", nil, { "type" => "text/javascript", "src" => source }.merge(options))
+      }.join("\n")
     end

     def stylesheet_link_merged(*sources)

"AssetPackager released!" by Jyrki J. Lilja

Tue, 26 Feb 2008 05:00:32 -0800

Hello! Thanks for great plugin =) I ran into a problem with javascript_include_merged, which, for some odd reason adds the querystring timestamp to src. Is there any solution, because my JS is over 100 kB and is hard for bandwitch because it’s transferred every time I load the page.

Thanks in advance, Jyrki J.

"AssetPackager released!" by Alf Mikula

Wed, 13 Feb 2008 18:03:57 -0800

So sorry about the duplicate posts! Some weird latency problem caused the interface not to respond, then to my horror there are all these posts that I can’t delete!

"AssetPackager released!" by Alf Mikula

Wed, 13 Feb 2008 18:03:04 -0800

I ran into a problem with adding a single javascript file to the asset_packages.yml file. Since the svn version number on the new file was older than the previous version, asset_packager didn’t build a new file, and likewise, browsers wouldn’t know that the file had changed because the version number didn’t change. I think since any change to asset_packages.yml could affect any of the packages, the version number of the asset_packages.yml needs to be included in the calculation. Here’s my patch:

http://pastie.caboo.se/151920

"AssetPackager released!" by Alf Mikula

Wed, 13 Feb 2008 18:02:33 -0800

http://pastie.caboo.se/151920

"AssetPackager released!" by Alf Mikula

Wed, 13 Feb 2008 18:02:01 -0800

http://pastie.caboo.se/151920

"AssetPackager released!" by Alf Mikula

Wed, 13 Feb 2008 18:01:33 -0800

http://pastie.caboo.se/151920

"AssetPackager released!" by Alf Mikula

Wed, 13 Feb 2008 18:01:31 -0800

http://pastie.caboo.se/151920

"AssetPackager released!" by Richard

Tue, 12 Feb 2008 17:04:02 -0800

Fantastic Plugin!

Package Version Numbers!

We ran into an issue when building the asset packages where we modified the asset_packages.yml and hadn’t modified any of the js files. This caused an issue where the version of the packaged files didn’t change thus any browser that had cached the previous version didn’t get the changes.

We therefore have included in the asset_package.rb on revision method:


      def revision
        unless @revision
          revisions = [1]
          revisions << get_file_revision("#{@asset_path}/../../config/asset_packages.yml")
          @sources.each do |source|
            revisions << get_file_revision("#{@asset_path}/#{source}.#{@extension}")
          end
          @revision = revisions.max
        end
        @revision
      end

Notice that we now include the asset_packages.yml version in the max lookup.

"AssetPackager released!" by Ryan Kuykendall

Thu, 07 Feb 2008 16:41:53 -0800

Asset packager is a fantastic plugin. Per a comment above (about Dir.entries instead of Dir.new(...).entries, couldn’t the following code be further simplified from this:

    def current_file                                                                                                                                                                             
      @target_dir.gsub(/^(.+)$/, '\1/') +                                                                                                                                                        
        Dir.new(@asset_path).entries.delete_if { |x| ! (x =~ @match_regex) }.sort.reverse[0].chomp(".#{@extension}")                                                                                 
    end

To this (grab the last item instead of reversing the list to grab the [0] element…also do x !~ regex rather than ! ( x =~ regex)):

    def current_file                                                                                                                                                                             
      @target_dir.gsub(/^(.+)$/, '\1/') +                                                                                                                                                        
        Dir.new(@asset_path).entries.delete_if { |x| x !~ @match_regex}.sort.last.chomp(".#{@extension}")                                                                                 
    end

Also, if I am reading the code correctly, with every page serve, the stylesheets or javascripts directory are being read for the most recent version of the file listed in the yaml file. Wouldn’t it be better, once the filename/path has been determined, to cache it in a class variable (since files are not being dynamically added to the assets directories?) Maybe like this:

    @@cached_asset_file_paths = {:css => {}, :js => {}}

    def current_file
      unless @@cached_asset_file_paths[@extension.to_sym].has_key?([@target.to_sym])
          @@cached_asset_file_paths[@extension.to_sym][@target.to_sym] = @target_dir.gsub(/^(.+)$/, '\1/') +                                                                                                                                                        
            Dir.new(@asset_path).entries.delete_if { |x| x !~ @match_regex}.sort.last.chomp(".#{@extension}")
      end

      @@cached_asset_file_paths[@extension.to_sym][@target.to_sym]                                                                                 
    end

Thanks again for a great plugin. Definitely makes my site feel snappier.

"AssetPackager released!" by bloggingdeveloper

Tue, 29 Jan 2008 09:40:14 -0800

Another free online tool for compressing javascript is http://www.compressjavascript.com

cheers, blogging developer http://www.bloggingdeveloper.com